Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 228003005: Remove redundancy in source map entries. (Closed)

Created:
6 years, 8 months ago by zarah
Modified:
6 years, 8 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove redundancy in source map entries. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=34866

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Changed command path. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -131 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/source_map_builder.dart View 6 chunks +58 lines, -7 lines 0 comments Download
D tests/compiler/dart2js/source_map_consistency_helper.dart View 1 chunk +0 lines, -58 lines 0 comments Download
D tests/compiler/dart2js/source_map_d2js_consistency_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
A + tests/compiler/dart2js/source_map_d2js_validity_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
D tests/compiler/dart2js/source_map_pub_build_consistency_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
A + tests/compiler/dart2js/source_map_pub_build_validity_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
A tests/compiler/dart2js/source_map_validator_helper.dart View 1 chunk +89 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zarah
6 years, 8 months ago (2014-04-08 10:48:40 UTC) #1
Johnni Winther
Otherwise LGTM https://codereview.chromium.org/228003005/diff/20001/tests/compiler/dart2js/source_map_pub_build_validity_test.dart File tests/compiler/dart2js/source_map_pub_build_validity_test.dart (right): https://codereview.chromium.org/228003005/diff/20001/tests/compiler/dart2js/source_map_pub_build_validity_test.dart#newcode21 tests/compiler/dart2js/source_map_pub_build_validity_test.dart:21: '../../../../out/ReleaseIA32/dart-sdk/bin/pub${ext}')); This seems wrong.
6 years, 8 months ago (2014-04-09 09:34:55 UTC) #2
zarah
6 years, 8 months ago (2014-04-09 09:49:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r34866 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698