Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 227993002: Revert "Adding additional debug information for JS errors in the DOM." (Closed)

Created:
6 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Adding additional debug information for JS errors in the DOM." Some tests broke, for instance: http://chromegw.corp.google.com/i/client.dart/builders/dart2js-ff-linux-2-4-be/builds/4732/steps/dart2js-ff%20tests/logs/stdio We are reverting r34803 until we figure out what's wrong: Committed: https://code.google.com/p/dart/source/detail?r=34808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M sdk/lib/_internal/lib/js_helper.dart View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
tbr
6 years, 8 months ago (2014-04-08 01:18:59 UTC) #1
Siggi Cherem (dart-lang)
Committed patchset #1 manually as r34808 (presubmit successful).
6 years, 8 months ago (2014-04-08 01:19:10 UTC) #2
Emily Fortuna
6 years, 8 months ago (2014-04-10 15:41:03 UTC) #3
Message was sent while issue was closed. 
lgtm. thank you.

Powered by Google App Engine
This is Rietveld 408576698