Issue 22798006: Implement Error.stackTrace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22798006: Implement Error.stackTrace. (Closed)

Created:
7 years, 4 months ago by ahe

Modified:
7 years, 4 months ago

Reviewers:
bakster, karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement Error.stackTrace. BUG=http://dartbug.com/11681 R=bak@google.com Committed: https://code.google.com/p/dart/source/detail?r=26004

Patch Set 2 : Address comments, update status file, and fix another test. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -18 lines)			Patch
M	dart/sdk/lib/_internal/lib/core_patch.dart	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/js_helper.dart	View	1	9 chunks	+31 lines, -11 lines	0 comments	Download
M	dart/tests/corelib/corelib.status	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	dart/tests/language/language_dart2js.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bakster

LGTM https://codereview.chromium.org/22798006/diff/1/dart/sdk/lib/_internal/lib/js_helper.dart File dart/sdk/lib/_internal/lib/js_helper.dart (right): https://codereview.chromium.org/22798006/diff/1/dart/sdk/lib/_internal/lib/js_helper.dart#newcode1151 dart/sdk/lib/_internal/lib/js_helper.dart:1151: saveStackTrace(error) { Please add a comment explaining the ...

7 years, 4 months ago (2013-08-12 14:08:50 UTC) #2

ahe

Committed patchset #2 manually as r26004 (presubmit successful).

7 years, 4 months ago (2013-08-12 14:42:10 UTC) #3

ahe

7 years, 4 months ago (2013-08-12 14:44:49 UTC) #4

Message was sent while issue was closed.

Thank you, Lars.

I also made a few minor adjustment to get corelib/error_stack_trace_test to
pass.

https://codereview.chromium.org/22798006/diff/1/dart/sdk/lib/_internal/lib/js...
File dart/sdk/lib/_internal/lib/js_helper.dart (right):

https://codereview.chromium.org/22798006/diff/1/dart/sdk/lib/_internal/lib/js...
dart/sdk/lib/_internal/lib/js_helper.dart:1151: saveStackTrace(error) {
On 2013/08/12 14:08:51, bakster wrote:
> Please add a comment explaining the behavior of this wrapper function.

Done.

Expand Messages | Collapse Messages

Issue 22798006: Implement Error.stackTrace. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comments, update status file, and fix another test. #

Messages