Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 227913007: Report the correct error, when recursive delete fails on Windows. (Closed)

Created:
6 years, 8 months ago by Anders Johnsen
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, ricow1
Visibility:
Public.

Description

Report the correct error, when recursive delete fails on Windows. BUG= R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=34933

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M runtime/bin/directory_win.cc View 1 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Anders Johnsen
6 years, 8 months ago (2014-04-10 16:53:33 UTC) #1
ricow1
lgtm
6 years, 8 months ago (2014-04-10 17:05:11 UTC) #2
Anders Johnsen
Committed patchset #2 manually as r34933 (presubmit successful).
6 years, 8 months ago (2014-04-10 17:13:29 UTC) #3
Søren Gjesse
lgtm
6 years, 8 months ago (2014-04-11 07:44:10 UTC) #4
Bill Hesse
6 years, 8 months ago (2014-04-11 07:45:55 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698