Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 227743009: [polymer] fix imports in Dartium if no script is on the main page (Closed)

Created:
6 years, 8 months ago by Jennifer Messerly
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

[polymer] fix imports in Dartium if no script is on the main page R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=34805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -32 lines) Patch
M pkg/polymer/lib/boot.js View 2 chunks +4 lines, -26 lines 0 comments Download
M pkg/polymer/lib/polymer.html View 2 chunks +6 lines, -5 lines 0 comments Download
M pkg/polymer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
Not sure how to automated test this, since the very presence of any test_support.js file ...
6 years, 8 months ago (2014-04-08 00:12:52 UTC) #1
Siggi Cherem (dart-lang)
lgtm! Thanks for helping out with this John!
6 years, 8 months ago (2014-04-08 00:20:51 UTC) #2
Jennifer Messerly
6 years, 8 months ago (2014-04-08 00:30:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34805 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698