Improve analysis_server/protocol.dart test coverage.

Improve analysis_server/protocol.dart test coverage.

R=brianwilkerson@google.com, danrubel@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=34794

[Brian Wilkerson, 2014-04-07 18:51:48]

LGTM

https://codereview.chromium.org/227713004/diff/1/pkg/analysis_server/test/pro...
File pkg/analysis_server/test/protocol_test.dart (right):

https://codereview.chromium.org/227713004/diff/1/pkg/analysis_server/test/pro...
pkg/analysis_server/test/protocol_test.dart:168: expect(request.toBool('false'),
isFalse);
Might be good to add a test for a string that is neither 'true' nor 'false'
(like 'abc').

https://codereview.chromium.org/227713004/diff/1/pkg/analysis_server/test/pro...
pkg/analysis_server/test/protocol_test.dart:209: static void create_parseError()
{
nit: We should probably be consistent with spacing. I like the blank lines
between members, but we can discuss if you feel strongly.

[danrubel, 2014-04-07 19:00:13]

lgtm

[scheglov, 2014-04-07 19:01:14]

Committed patchset #1 manually as r34794 (presubmit successful).

[scheglov, 2014-04-07 19:01:41]

https://codereview.chromium.org/227713004/diff/1/pkg/analysis_server/test/pro...
File pkg/analysis_server/test/protocol_test.dart (right):

https://codereview.chromium.org/227713004/diff/1/pkg/analysis_server/test/pro...
pkg/analysis_server/test/protocol_test.dart:168: expect(request.toBool('false'),
isFalse);
On 2014/04/07 18:51:48, Brian Wilkerson wrote:
> Might be good to add a test for a string that is neither 'true' nor 'false'
> (like 'abc').

Done.

https://codereview.chromium.org/227713004/diff/1/pkg/analysis_server/test/pro...
pkg/analysis_server/test/protocol_test.dart:209: static void create_parseError()
{
On 2014/04/07 18:51:48, Brian Wilkerson wrote:
> nit: We should probably be consistent with spacing. I like the blank lines
> between members, but we can discuss if you feel strongly.

Agree, we need to put an empty line between members.
Fixed.