Fix instance method resolution with abstract accessors and methods

Fix instance method resolution with abstract accessors and methods

Fix issue 18082

R=gbracha@google.com, regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34845

[regis, 2014-04-08 18:02:10]

Can you explain what exactly this fixes? I do not get it.

https://codereview.chromium.org/227703010/diff/1/tests/language/abstract_meth...
File tests/language/abstract_method_test.dart (right):

https://codereview.chromium.org/227703010/diff/1/tests/language/abstract_meth...
tests/language/abstract_method_test.dart:1: // Copyright (c) 2011, the Dart
project authors.  Please see the AUTHORS file
2014

https://codereview.chromium.org/227703010/diff/1/tests/language/abstract_meth...
tests/language/abstract_method_test.dart:19: get useLength => length;
I am not sure I understand the difference your fix makes for this test. This
call to length should resolve to the getter in the subclass, whether you have an
abstract getter in A or not.
Your fix seems to take abstract methods into consideration that were not
considered before.

[gbracha, 2014-04-08 19:14:08]

test lgtm

[hausner, 2014-04-08 19:47:19]

Hope this explains my CL.

https://codereview.chromium.org/227703010/diff/1/tests/language/abstract_meth...
File tests/language/abstract_method_test.dart (right):

https://codereview.chromium.org/227703010/diff/1/tests/language/abstract_meth...
tests/language/abstract_method_test.dart:1: // Copyright (c) 2011, the Dart
project authors.  Please see the AUTHORS file
On 2014/04/08 18:02:11, regis wrote:
> 2014
Oh, it's already 2014? Done.

https://codereview.chromium.org/227703010/diff/1/tests/language/abstract_meth...
tests/language/abstract_method_test.dart:19: get useLength => length;
On 2014/04/08 18:02:11, regis wrote:
> I am not sure I understand the difference your fix makes for this test. This
> call to length should resolve to the getter in the subclass, whether you have
an
> abstract getter in A or not.
> Your fix seems to take abstract methods into consideration that were not
> considered before.

Correct. Before this change. We searched for "length" in the local scope, then
in the scope of class A, and didn't find anything (because abstract methods were
not considered.) Thus, the name "length" resolved to the top-level entity.

With this change, we find the (abstract) getter "length" in class A and thus
generate an instance call to the getter, rather than a static call to the
top-level getter.

[regis, 2014-04-08 22:12:41]

LGTM!

Thanks for the explanation. I am still not used to the fact that lexical scoping
takes precedence over inheritance in Dart and get easily confused :-)

[hausner, 2014-04-08 22:14:30]

Committed patchset #2 manually as r34845 (presubmit successful).