Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 227683004: Reset growth control state after isolate initialization. (Closed)

Created:
6 years, 8 months ago by koda
Modified:
6 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, kasperl
Visibility:
Public.

Description

Reset growth control state after isolate initialization. (a) When enabling the growth control, e.g. after isolate initialization, the current usage should be the new basis for growth control. This is consistent with the behavior before r34747. (b) Advise GC only when the number of allowed pages has been (strictly) exceeded, rather than met. This is consistent with the behavior before r34747. Part (a) fixes the Havlak performance regression (3%). R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=34793

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M runtime/vm/pages.h View 3 chunks +13 lines, -5 lines 0 comments Download
M runtime/vm/pages.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
6 years, 8 months ago (2014-04-07 18:35:16 UTC) #1
Ivan Posva
LGTM -ip
6 years, 8 months ago (2014-04-07 18:38:05 UTC) #2
koda
6 years, 8 months ago (2014-04-07 18:40:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r34793 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698