Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2276143002: Loosen dependency override validation. (Closed)

Created:
4 years, 4 months ago by nweiz
Modified:
4 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Loosen dependency override validation. This allows packages that override only dev dependencies to be published. Closes #1444 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/3a96c86ab75255e114eb47aaadf4f1f81cf056b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -4 lines) Patch
M lib/src/validator/dependency_override.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M test/validator/dependency_override_test.dart View 2 chunks +39 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 4 months ago (2016-08-24 21:08:26 UTC) #1
Bob Nystrom
lgtm
4 years, 4 months ago (2016-08-25 00:31:03 UTC) #2
nweiz
4 years, 4 months ago (2016-08-25 00:32:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3a96c86ab75255e114eb47aaadf4f1f81cf056b7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698