Issue 22759003: Report INVALID_ASSIGNMENT if default value type cannot be assigned to the parameter type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22759003: Report INVALID_ASSIGNMENT if default value type cannot be assigned to the parameter type. (Closed)

Created:
7 years, 4 months ago by scheglov

Modified:
7 years, 4 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Report INVALID_ASSIGNMENT if default value type cannot be assigned to the parameter type. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=26010

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -7 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticTypeWarningCodeTest.java	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	tests/language/language_analyzer.status	View	2 chunks	+0 lines, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

jwren

On 2013/08/09 22:32:40, scheglov wrote: LGTM! Great work Konstantin.

7 years, 4 months ago (2013-08-09 22:59:59 UTC) #2

scheglov

7 years, 4 months ago (2013-08-12 16:10:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r26010 (presubmit successful).