Issue 22755002: Move matches method so that it gets generated for dart2js and dartium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22755002: Move matches method so that it gets generated for dart2js and dartium. (Closed)

Created:
7 years, 4 months ago by Emily Fortuna

Modified:
7 years, 4 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move matches method so that it gets generated for dart2js and dartium. BUG= Committed: https://code.google.com/p/dart/source/detail?r=25970

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -5 lines)			Patch
	M	sdk/lib/html/dartium/html_dartium.dart	View		2 chunks	+20 lines, -3 lines	1 comment	Download
	M	tools/dom/templates/html/impl/impl_Element.darttemplate	View		2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

TBR. this function was in the wrong part of the template

7 years, 4 months ago (2013-08-09 18:34:25 UTC) #1

Emily Fortuna

Committed patchset #1 manually as r25970 (presubmit successful).

7 years, 4 months ago (2013-08-09 18:35:04 UTC) #2

blois

7 years, 4 months ago (2013-08-09 18:38:57 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/22755002/diff/1/sdk/lib/html/dartium/html_dar...
File sdk/lib/html/dartium/html_dartium.dart (right):

https://codereview.chromium.org/22755002/diff/1/sdk/lib/html/dartium/html_dar...
sdk/lib/html/dartium/html_dartium.dart:9285: +  bool matches(String selectors) {
Isn't this JS-specific syntax?

Wasn't this already there?

Expand Messages | Collapse Messages