Issue 227533005: Add new performance option

Issue 227533005: Add new performance option (Closed)

Created:
6 years, 8 months ago by Brian Wilkerson

Modified:
6 years, 8 months ago

Reviewers:
ricow1, scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add new performance option to get both cold and warm timings. @Rico: Does it matter that the errors will be written between the two sets of timings? R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=34817

Patch Set 1 #

Patch Set 2 : Bug fixes #

Total comments: 4

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -16 lines)			Patch
M	editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerMain.java	View		2 chunks	+47 lines, -0 lines	2 comments	Download
M	editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerOptions.java	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/PerformanceStatistics.java	View		1 chunk	+22 lines, -8 lines	0 comments	Download
M	pkg/analyzer/bin/analyzer.dart	View	1	2 chunks	+19 lines, -1 line	2 comments	Download
M	pkg/analyzer/lib/options.dart	View		3 chunks	+7 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/analyzer_impl.dart	View	1	5 chunks	+37 lines, -7 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/engine.dart	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scheglov

https://codereview.chromium.org/227533005/diff/20001/editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerMain.java File editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerMain.java (right): https://codereview.chromium.org/227533005/diff/20001/editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerMain.java#newcode261 editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerMain.java:261: private void showColdPerformanceResults(long startTime) { Maybe pass "-cold" prefix ...

6 years, 8 months ago (2014-04-07 19:20:30 UTC) #2

Brian Wilkerson

6 years, 8 months ago (2014-04-07 20:05:16 UTC) #3

Brian Wilkerson

6 years, 8 months ago (2014-04-08 11:08:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r34817 (presubmit successful).

Expand Messages | Collapse Messages