Issue 227153010: Change HtmlCollection to appear as List<Node> and getElementsByX return ListNode|HtmlCollection (de…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 227153010: Change HtmlCollection to appear as List<Node> and getElementsByX return ListNode|HtmlCollection (de… (Closed)

Created:
6 years, 8 months ago by Emily Fortuna

Modified:
6 years, 8 months ago

Reviewers:
vsm, sra1, blois

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change HtmlCollection to appear as List<Node> and getElementsByX return ListNode|HtmlCollection (depending on browser). BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=34799

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+171 lines, -36 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	14 chunks	+80 lines, -16 lines	1 comment	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	15 chunks	+59 lines, -19 lines	0 comments	Download
M	tools/dom/scripts/dartmetadata.py	View	3 chunks	+30 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

https://codereview.chromium.org/227153010/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/227153010/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode16414 sdk/lib/html/dart2js/html_dart2js.dart:16414: +@DomName('InstallEvent') a clean tree also adds these two Events, ...

6 years, 8 months ago (2014-04-07 20:39:00 UTC) #1

Emily Fortuna

+vsm I'd like to get this in today soon-ish so I can monitor any performance ...

6 years, 8 months ago (2014-04-07 22:12:18 UTC) #2

Emily Fortuna

6 years, 8 months ago (2014-04-07 22:23:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r34799 (presubmit successful).

Expand Messages | Collapse Messages