Issue 22710009: Report INSTANCE_ACCESS_TO_STATIC_MEMBER.

Issue 22710009: Report INSTANCE_ACCESS_TO_STATIC_MEMBER. (Closed)

Created:
7 years, 4 months ago by scheglov

Modified:
7 years, 4 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report INSTANCE_ACCESS_TO_STATIC_MEMBER. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=25984

Patch Set 2 : Fixes for review comments #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+176 lines, -28 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticTypeWarningCode.java	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	1	7 chunks	+69 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View	1	2 chunks	+1 line, -14 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java	View		1 chunk	+24 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticTypeWarningCodeTest.java	View	1	1 chunk	+65 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/co19/co19-analyzer.status	View		4 chunks	+8 lines, -5 lines	0 comments	Download
M	tests/language/language_analyzer.status	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jwren

LGTM https://codereview.chromium.org/22710009/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java (right): https://codereview.chromium.org/22710009/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java#newcode3029 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:3029: if (target.getParent().getParent() instanceof CommentReference) { Nit: wouldn't it ...

7 years, 4 months ago (2013-08-09 19:42:06 UTC) #2

Brian Wilkerson

LGTM https://codereview.chromium.org/22710009/diff/1/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java File editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java (right): https://codereview.chromium.org/22710009/diff/1/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java#newcode387 editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java:387: StaticTypeWarningCode.INSTANCE_ACCESS_TO_STATIC_MEMBER); Can we remove the warning without hurting ...

7 years, 4 months ago (2013-08-09 19:49:53 UTC) #3

scheglov

https://codereview.chromium.org/22710009/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java (right): https://codereview.chromium.org/22710009/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java#newcode3029 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:3029: if (target.getParent().getParent() instanceof CommentReference) { On 2013/08/09 19:42:06, jwren ...

7 years, 4 months ago (2013-08-09 22:10:05 UTC) #4

https://codereview.chromium.org/22710009/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
(right):

https://codereview.chromium.org/22710009/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:3029:
if (target.getParent().getParent() instanceof CommentReference) {
On 2013/08/09 19:42:06, jwren wrote:
> Nit: wouldn't it be a bit more robust to have a boolean such as "isInComment" 
> (like isInCatchClause) which is tested against here instead of the multiple
> getParent() calls?

Done.

https://codereview.chromium.org/22710009/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java
(right):

https://codereview.chromium.org/22710009/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java:387:
StaticTypeWarningCode.INSTANCE_ACCESS_TO_STATIC_MEMBER);
On 2013/08/09 19:49:54, Brian Wilkerson wrote:
> Can we remove the warning without hurting the test for the error? I'd prefer
> having only the error/warning being tested for getting generated. (I think it
> will be easier to maintain the tests.)

Done.
I will remove this test.
It is not required.
What is actually tested here is that we report an error when target of prefixed
identifier in not a constant.
I will rename previous test to express this.

https://codereview.chromium.org/22710009/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticTypeWarningCodeTest.java
(right):

https://codereview.chromium.org/22710009/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticTypeWarningCodeTest.java:86:
public void test_instanceAccessToStaticMember() throws Exception {
On 2013/08/09 19:49:54, Brian Wilkerson wrote:
> The first three test cases appear to be the same. Am I missing something, or
are
> they really redundant?

Done.
First two are actually duplicates.
Third is different - method reference vs. method invocation.

scheglov

7 years, 4 months ago (2013-08-09 22:10:39 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r25984 (presubmit successful).

Expand Messages | Collapse Messages