Fixed too many files being open

Fixed too many files being open

BUG=
R=efortuna@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25950

[Tate Mandel, 2013-08-08 21:05:25]

This should fix the "Too many open files" error.

In the old version, /proc/sys/fs/file-nr shows 8032 files open at start of
execution and 8896 just before finishing execution of docgen on the SDK.

In the new version, the number doesn't change throughout execution.

[Emily Fortuna, 2013-08-08 21:07:56]

looks good -- just one question

https://codereview.chromium.org/22706004/diff/1/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/22706004/diff/1/pkg/docgen/lib/docgen.dart#ne...
pkg/docgen/lib/docgen.dart:486: file.writeAsStringSync(text, mode: append ?
FileMode.APPEND : FileMode.WRITE);
did you time this on linux? does this increase the run time? If so, could you
maybe just run the async version on linux and the sync version on mac?

[Tate Mandel, 2013-08-08 21:19:13]

https://codereview.chromium.org/22706004/diff/1/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/22706004/diff/1/pkg/docgen/lib/docgen.dart#ne...
pkg/docgen/lib/docgen.dart:486: file.writeAsStringSync(text, mode: append ?
FileMode.APPEND : FileMode.WRITE);
On 2013/08/08 21:07:56, Emily Fortuna wrote:
> did you time this on linux? does this increase the run time? If so, could you
> maybe just run the async version on linux and the sync version on mac?

I ran each version several times on Linux. 
This version ran in 8.0 +- .2sec every time.
The original ran in 10.0 +- .2sec every time.

Both writeAsString and writeAsStringSync claim to close the file after writing
to it in the docs, but it doesn't seem to be true for the former. The extra
memory usage could cause it to be slower despite being asynchronous.

[Emily Fortuna, 2013-08-08 21:58:22]

lgtm

https://codereview.chromium.org/22706004/diff/1/pkg/docgen/lib/docgen.dart
File pkg/docgen/lib/docgen.dart (right):

https://codereview.chromium.org/22706004/diff/1/pkg/docgen/lib/docgen.dart#ne...
pkg/docgen/lib/docgen.dart:486: file.writeAsStringSync(text, mode: append ?
FileMode.APPEND : FileMode.WRITE);
On 2013/08/08 21:19:13, Tate Mandel wrote:
> On 2013/08/08 21:07:56, Emily Fortuna wrote:
> > did you time this on linux? does this increase the run time? If so, could
you
> > maybe just run the async version on linux and the sync version on mac?
> 
> I ran each version several times on Linux. 
> This version ran in 8.0 +- .2sec every time.
> The original ran in 10.0 +- .2sec every time.
> 
> Both writeAsString and writeAsStringSync claim to close the file after writing
> to it in the docs, but it doesn't seem to be true for the former. The extra
> memory usage could cause it to be slower despite being asynchronous.

Curious! Well, I'm convinced! After you submit this, can you file a bug at
dartbug.com/new about this? People with the io library should investigate what's
going on and make sure it's actually doing what they intend it to be doing. :-)

[Tate Mandel, 2013-08-08 22:02:11]

Committed patchset #1 manually as r25950 (presubmit successful).