Issue 226953003: Revert "Compute frontend/backend specific constants."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 226953003: Revert "Compute frontend/backend specific constants." (Closed)

Created:
6 years, 8 months ago by Johnni Winther

Modified:
6 years, 8 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Compute frontend/backend specific constants." This reverts commit r34811. BUG= Committed: https://code.google.com/p/dart/source/detail?r=34816

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+290 lines, -763 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/common.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/compile_time_constants.dart	View	7 chunks	+172 lines, -181 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	4 chunks	+9 lines, -22 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart	View	3 chunks	+0 lines, -62 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/deferred_load.dart	View	7 chunks	+11 lines, -22 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/elements.dart	View	2 chunks	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/inferrer/simple_types_inferrer.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	5 chunks	+9 lines, -16 lines	0 comments	Download
D	sdk/lib/_internal/compiler/implementation/js_backend/constant_handler_javascript.dart	View	1 chunk	+0 lines, -209 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/js_backend.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart	View	3 chunks	+5 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/interceptor_emitter.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/js_emitter.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirrors/dart2js_member_mirrors.dart	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirrors_used.dart	View	4 chunks	+10 lines, -12 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	10 chunks	+36 lines, -33 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	6 chunks	+8 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/exit_code_test.dart	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	tests/compiler/dart2js/mirrors_used_test.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
D	tests/language/const_constructor3_test.dart	View	1 chunk	+0 lines, -24 lines	0 comments	Download
D	tests/language/const_evaluation_test.dart	View	1 chunk	+0 lines, -49 lines	0 comments	Download
D	tests/language/const_init2_test.dart	View	1 chunk	+0 lines, -11 lines	0 comments	Download
D	tests/language/const_switch2_test.dart	View	1 chunk	+0 lines, -15 lines	0 comments	Download
D	tests/language/const_switch_test.dart	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	2 chunks	+0 lines, -3 lines	0 comments	Download
D	tests/language/proxy3_test.dart	View	1 chunk	+0 lines, -24 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

Committed patchset #2 manually as r34816 (presubmit successful).

6 years, 8 months ago (2014-04-08 10:19:55 UTC) #2

Message was sent while issue was closed.

LGTM.

Expand Messages | Collapse Messages