Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 226953002: Implement deferred constant support (Closed)

Created:
6 years, 8 months ago by hausner
Modified:
6 years, 8 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Implement deferred constant support Compile time constants lose their const-ness if they are referred to through a deferred prefix. This CL adds a flag to some ast node types that remembers whether a field or closure was referred to via a deferred prefix. If so, the compile-time const analysis flags the value as non-const. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=34785

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -35 lines) Patch
M runtime/vm/ast.h View 1 2 11 chunks +22 lines, -6 lines 0 comments Download
M runtime/vm/ast.cc View 1 2 3 chunks +8 lines, -1 line 0 comments Download
M runtime/vm/parser.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 6 chunks +47 lines, -22 lines 0 comments Download
M tests/language/language.status View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
6 years, 8 months ago (2014-04-07 17:10:21 UTC) #1
srdjan
lgtm https://codereview.chromium.org/226953002/diff/20001/runtime/vm/ast.h File runtime/vm/ast.h (right): https://codereview.chromium.org/226953002/diff/20001/runtime/vm/ast.h#newcode1168 runtime/vm/ast.h:1168: if (is_deferred_reference_) printf("DDDDD\n"); Why only four Ds?
6 years, 8 months ago (2014-04-07 17:19:10 UTC) #2
hausner
Thank you. https://codereview.chromium.org/226953002/diff/20001/runtime/vm/ast.h File runtime/vm/ast.h (right): https://codereview.chromium.org/226953002/diff/20001/runtime/vm/ast.h#newcode1168 runtime/vm/ast.h:1168: if (is_deferred_reference_) printf("DDDDD\n"); On 2014/04/07 17:19:10, srdjan ...
6 years, 8 months ago (2014-04-07 17:30:27 UTC) #3
hausner
6 years, 8 months ago (2014-04-07 17:31:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r34785 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698