Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2269403002: Add a packageResolver parameter to runInIsolate(). (Closed)

Created:
4 years, 4 months ago by nweiz
Modified:
4 years, 4 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a packageResolver parameter to runInIsolate(). This isn't used by test proper, but it's needed by some Google-internal code. R=jmesserly@google.com Committed: https://github.com/dart-lang/test/commit/7ad2b1cad415f6af21755ca1e457f11d35255ba4

Patch Set 1 #

Patch Set 2 : Bump pubspec and changelog. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M CHANGELOG.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/util/dart.dart View 2 chunks +9 lines, -3 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 4 months ago (2016-08-24 00:40:09 UTC) #1
Jennifer Messerly
lgtm!
4 years, 4 months ago (2016-08-24 00:43:56 UTC) #2
nweiz
4 years, 4 months ago (2016-08-24 01:18:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7ad2b1cad415f6af21755ca1e457f11d35255ba4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698