- Change access pattern to Native Arguments (make one call instead of two).

- Add a new toNative which accepts Dart_NativeArguments as a parameter.
  Currently it is implemented as two calls to the API to get at the native
  wrapper (will be made one call in another CL).
- Use the new API call Dart_SetWeakHandleReturnValue to return a string
  from the cache directly without having to call Dart_NewHandle(...)

R=vsm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26148

[vsm, 2013-08-12 20:42:07]

https://codereview.chromium.org/22694004/diff/3001/tools/dom/scripts/systemna...
File tools/dom/scripts/systemnative.py (right):

https://codereview.chromium.org/22694004/diff/3001/tools/dom/scripts/systemna...
tools/dom/scripts/systemnative.py:380: '    static $RETURN_TYPE
toNativeWithNullCheck(Dart_NativeArguments args, int index, Dart_Handle&
exception)$TO_NATIVE_ARG_BODY\n',
Why do we have both of these with the same implementation?

[siva, 2013-08-13 17:52:52]

https://codereview.chromium.org/22694004/diff/3001/tools/dom/scripts/systemna...
File tools/dom/scripts/systemnative.py (right):

https://codereview.chromium.org/22694004/diff/3001/tools/dom/scripts/systemna...
tools/dom/scripts/systemnative.py:380: '    static $RETURN_TYPE
toNativeWithNullCheck(Dart_NativeArguments args, int index, Dart_Handle&
exception)$TO_NATIVE_ARG_BODY\n',
On 2013/08/12 20:42:07, vsm wrote:
> Why do we have both of these with the same implementation?

toNativeNullCheck wants to protect against Null being passed in by
returning 0 but if you look at toNative it already does that, the two
calls are identical. It is just that the generation pattern makes it
hard to get rid of calls to 'toNativeNullCheck'

I have changed 'toNativeNullCheck to just call toNative and added a
comment.

[vsm, 2013-08-13 18:46:23]

lgtm

[siva, 2013-08-14 16:43:00]

Found a bug in the generated setDartStringReturnValue.... code while running
tests. Needed to account for the Null case.

PTAL

[vsm, 2013-08-14 20:04:44]

lgtm

[siva, 2013-08-14 20:45:44]

Committed patchset #4 manually as r26148 (presubmit successful).