Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2268153003: Fix a crash. (Closed)

Created:
4 years, 4 months ago by nweiz
Modified:
4 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/package_resolver@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a crash. We were choking on URIs without path components. This doesn't come up frequently for file: URIs, but it's common for http: URIs. R=rnystrom@google.com Committed: https://github.com/dart-lang/package_resolver/commit/7cbba6d96b1d74e676164d3a7a871fbafd837c0c

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M CHANGELOG.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/utils.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/package_root_info_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 4 months ago (2016-08-24 00:36:10 UTC) #1
Bob Nystrom
lgtm https://codereview.chromium.org/2268153003/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2268153003/diff/1/CHANGELOG.md#newcode3 CHANGELOG.md:3: * Don't crash on URIs path components. "without"
4 years, 4 months ago (2016-08-24 16:04:54 UTC) #2
nweiz
Code review changes
4 years, 4 months ago (2016-08-24 19:33:31 UTC) #3
nweiz
https://codereview.chromium.org/2268153003/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2268153003/diff/1/CHANGELOG.md#newcode3 CHANGELOG.md:3: * Don't crash on URIs path components. On 2016/08/24 ...
4 years, 4 months ago (2016-08-24 19:38:07 UTC) #4
nweiz
4 years, 4 months ago (2016-08-24 19:38:22 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
7cbba6d96b1d74e676164d3a7a871fbafd837c0c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698