Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 226543007: Implement new stacktrace and deoptimization stress testing flags: (Closed)

Created:
6 years, 8 months ago by turnidge
Modified:
6 years, 8 months ago
Reviewers:
zra, Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Implement new stacktrace and deoptimization stress testing flags: --deoptimize-every=N --deoptimize-filter=FunctionName --stacktrace-every=N --stacktrace-filter=FunctionName Add a word of stack_overflow_flags to the Isolate. Use a bit in this word to indicate whether or not a function is being compiler for OSR. This allows us to distinguish an OSR overflow from a stress-testing overflow. BUG= R=johnmccutchan@google.com, zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=34887

Patch Set 1 #

Total comments: 4

Patch Set 2 : code review changes #

Patch Set 3 : #

Patch Set 4 : 3rd times a charm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -36 lines) Patch
M runtime/vm/code_generator.cc View 1 2 3 5 chunks +74 lines, -20 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 2 chunks +21 lines, -7 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 3 chunks +19 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 4 chunks +19 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 4 chunks +20 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 3 chunks +19 lines, -1 line 0 comments Download
M runtime/vm/isolate.h View 3 chunks +21 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
turnidge
(Adding zra for mips/arm)
6 years, 8 months ago (2014-04-07 21:27:02 UTC) #1
Cutch
https://codereview.chromium.org/226543007/diff/1/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://codereview.chromium.org/226543007/diff/1/runtime/vm/code_generator.cc#newcode1080 runtime/vm/code_generator.cc:1080: if (stack_overflow_flags & Isolate::kOsrRequest) { (stack_overflow_flags & Isolate::kOsrRequest) != ...
6 years, 8 months ago (2014-04-07 23:19:57 UTC) #2
zra
arm and mips sequences lgtm
6 years, 8 months ago (2014-04-07 23:26:02 UTC) #3
turnidge
john - PTAL https://codereview.chromium.org/226543007/diff/1/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://codereview.chromium.org/226543007/diff/1/runtime/vm/code_generator.cc#newcode1080 runtime/vm/code_generator.cc:1080: if (stack_overflow_flags & Isolate::kOsrRequest) { On ...
6 years, 8 months ago (2014-04-09 17:22:02 UTC) #4
Cutch
lgtm
6 years, 8 months ago (2014-04-09 17:23:41 UTC) #5
turnidge
6 years, 8 months ago (2014-04-09 18:27:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r34887 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698