Issue 22642003: Fix name of libraries without a library declaration to be the empty string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22642003: Fix name of libraries without a library declaration to be the empty string. (Closed)

Created:
7 years, 4 months ago by rmacnak

Modified:
7 years, 4 months ago

Reviewers:
ahe, siva

CC:
reviews_dartlang.org, Michael Lippautz (Google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix name of libraries without a library declaration to be the empty string. BUG=10580 R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=25981

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -7 lines)			Patch
M	runtime/vm/dart_api_impl_test.cc	View		4 chunks	+11 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/lib.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A +	tests/lib/mirrors/unnamed_library_test.dart	View		1 chunk	+5 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

siva

Your change LGTM However I am wondering if the spec should state that a a ...

7 years, 4 months ago (2013-08-08 16:00:40 UTC) #2

rmacnak

7 years, 4 months ago (2013-08-09 21:27:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r25981 (presubmit successful).