Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 226393003: Correctly generate code when using transformers in polymer-expressions. (Closed)

Created:
6 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 8 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Correctly generate code when using transformers in polymer-expressions. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=34743

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M pkg/polymer/lib/src/build/script_compactor.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/polymer/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/build/script_compactor_test.dart View 5 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
6 years, 8 months ago (2014-04-04 19:19:08 UTC) #1
Jennifer Messerly
lgtm
6 years, 8 months ago (2014-04-04 19:45:45 UTC) #2
Siggi Cherem (dart-lang)
6 years, 8 months ago (2014-04-04 20:27:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r34743 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698