Issue 22638015: Prevent recursive exception notification in debugger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22638015: Prevent recursive exception notification in debugger (Closed)

Created:
7 years, 4 months ago by hausner

Modified:
7 years, 4 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, devoncarew, Alan Knight

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Prevent recursive exception notification in debugger Fixes bug 12329. Committed: https://code.google.com/p/dart/source/detail?r=25961

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	runtime/vm/debugger.cc	View		1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

Committed patchset #1 manually as r25961 (presubmit successful).

7 years, 4 months ago (2013-08-09 10:20:01 UTC) #2

Ivan Posva

7 years, 4 months ago (2013-08-09 16:31:34 UTC) #3

Message was sent while issue was closed.

Thanks for the quick turnaround!

This change LGTM, but we should prevent it in general.

-Ivan

https://codereview.chromium.org/22638015/diff/1/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/22638015/diff/1/runtime/vm/debugger.cc#newcod...
runtime/vm/debugger.cc:1072: (*event_handler_)(&event);
I think we should abstract the dispatch to the event handler out and have that
set and reset the in_event_notification status. That way all of the other,
currently unprotected, event_handler calls will automatically be protected from
similar issues.

Expand Messages | Collapse Messages