Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 22633005: Make reflectClass(dynamic) throw an illegal argument exception. (Closed)

Created:
7 years, 4 months ago by rmacnak
Modified:
7 years, 4 months ago
Reviewers:
ahe, gbracha, siva, Ivan Posva
CC:
reviews_dartlang.org, Michael Lippautz (Google)
Visibility:
Public.

Description

Make reflectClass(dynamic) throw an illegal argument exception. BUG= R=gbracha@google.com, iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=26550

Patch Set 1 : #

Patch Set 2 : note in api #

Patch Set 3 : #

Patch Set 4 : fix filtering comment, rebase, add issue number for failing test #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -10 lines) Patch
M runtime/lib/mirrors.cc View 1 2 3 4 5 3 chunks +17 lines, -9 lines 0 comments Download
M sdk/lib/mirrors/mirrors.dart View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M tests/lib/lib.status View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A tests/lib/mirrors/hierarchy_invariants_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rmacnak
This may break some users, and without http://dartbug.com/12246 I don't see they'd work around it.
7 years, 4 months ago (2013-08-09 22:45:59 UTC) #1
rmacnak
7 years, 4 months ago (2013-08-13 23:54:21 UTC) #2
rmacnak
With http://dartbug.com/12246 fixed, one could write reflectType(t){ if(t==dynamic) return currentMirrorSystem().dynamicType(); return reflectClass(t); } Also, dart2js ...
7 years, 4 months ago (2013-08-16 17:50:45 UTC) #3
gbracha
Dart files lgtm.
7 years, 4 months ago (2013-08-21 17:38:27 UTC) #4
rmacnak
Ping. Folks are hitting this (https://plus.google.com/100009996133924065020/posts/asjUHiwiu72).
7 years, 4 months ago (2013-08-22 17:55:28 UTC) #5
Ivan Posva
LGTM -ip
7 years, 4 months ago (2013-08-22 17:58:01 UTC) #6
rmacnak
7 years, 4 months ago (2013-08-22 20:05:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #6 manually as r26550 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698