Issue 226303002: Begin implementing flag --deoptimize-filter=FUNC for ia32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 226303002: Begin implementing flag --deoptimize-filter=FUNC for ia32. (Closed)

Created:
6 years, 8 months ago by turnidge

Modified:
6 years, 8 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Begin implementing flag --deoptimize-filter=FUNC for ia32. Currently not functional - committing so that srdjan can investigate why it doesn't work. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=34737

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -0 lines)			Patch
M	runtime/vm/code_generator.cc	View	1 2	2 chunks	+24 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/226303002/diff/1/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://codereview.chromium.org/226303002/diff/1/runtime/vm/code_generator.cc#newcode1233 runtime/vm/code_generator.cc:1233: const Code& code = Code::ZoneHandle(frame->LookupDartCode()); 'code' can be ...

6 years, 8 months ago (2014-04-04 17:55:22 UTC) #2

turnidge

6 years, 8 months ago (2014-04-04 18:05:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r34737 (presubmit successful).

Expand Messages | Collapse Messages