Issue 226273007: tests/html/xhr_test - progress is not called

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 226273007: tests/html/xhr_test - progress is not called (Closed)

Created:
6 years, 8 months ago by kevmoo

Modified:
6 years, 8 months ago

Reviewers:
Emily Fortuna, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

tests/html/xhr_test - progress is not called TBR Committed: https://code.google.com/p/dart/source/detail?r=34757

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	tests/html/html.status	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	tests/html/xhr_test.dart	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kevmoo

Committed patchset #1 manually as r34757 (presubmit successful).

6 years, 8 months ago (2014-04-05 17:46:09 UTC) #2

blois

https://codereview.chromium.org/226273007/diff/1/tests/html/xhr_test.dart File tests/html/xhr_test.dart (right): https://codereview.chromium.org/226273007/diff/1/tests/html/xhr_test.dart#newcode186 tests/html/xhr_test.dart:186: expect(progressCalled, isTrue, reason: 'onProgress should be fired'); The progress ...

6 years, 8 months ago (2014-04-07 15:36:17 UTC) #3

kevmoo

6 years, 8 months ago (2014-04-07 17:09:49 UTC) #4

Message was sent while issue was closed.

On 2014/04/07 15:36:17, blois wrote:
> https://codereview.chromium.org/226273007/diff/1/tests/html/xhr_test.dart
> File tests/html/xhr_test.dart (right):
> 
>
https://codereview.chromium.org/226273007/diff/1/tests/html/xhr_test.dart#new...
> tests/html/xhr_test.dart:186: expect(progressCalled, isTrue, reason:
'onProgress
> should be fired');
> The progress handler should just be removed- we have a separate test
> specifically for onProgress.

Pete: want to take a look at 18049 to clean this up?

Expand Messages | Collapse Messages