Make ClosureMirror handle instances of user-defined classes that implement call.

Make ClosureMirror handle instances of user-defined classes that implement call.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25944

[rmacnak, 2013-08-07 22:05:49]

This is half of

https://chromiumcodereview.appspot.com/22455003/

which omits the part the makes user-defined classes that implement call
reflected by FunctionTypeMirrors. This allows one to reflectively determine
whether some object is a real closure.

[siva, 2013-08-07 23:06:41]

https://codereview.chromium.org/22625003/diff/5001/runtime/lib/mirrors_impl.dart
File runtime/lib/mirrors_impl.dart (right):

https://codereview.chromium.org/22625003/diff/5001/runtime/lib/mirrors_impl.d...
runtime/lib/mirrors_impl.dart:615: if (_callMethod==null) {
missing spaces:
if (_callMethod == null) {

https://codereview.chromium.org/22625003/diff/5001/tests/lib/mirrors/fake_fun...
File tests/lib/mirrors/fake_function_test.dart (right):

https://codereview.chromium.org/22625003/diff/5001/tests/lib/mirrors/fake_fun...
tests/lib/mirrors/fake_function_test.dart:11: method();
Can you add a body for it so that it can be invoked and the result verified (see
comment below).

https://codereview.chromium.org/22625003/diff/5001/tests/lib/mirrors/fake_fun...
tests/lib/mirrors/fake_function_test.dart:25: "Wrong arity");
Can you also add a test to invoke "method" using cm.

[rmacnak, 2013-08-07 23:17:29]

On 2013/08/07 23:06:41, siva wrote:
>
https://codereview.chromium.org/22625003/diff/5001/runtime/lib/mirrors_impl.dart
> File runtime/lib/mirrors_impl.dart (right):
> 
>
https://codereview.chromium.org/22625003/diff/5001/runtime/lib/mirrors_impl.d...
> runtime/lib/mirrors_impl.dart:615: if (_callMethod==null) {
> missing spaces:
> if (_callMethod == null) {

Done.
> 
>
https://codereview.chromium.org/22625003/diff/5001/tests/lib/mirrors/fake_fun...
> File tests/lib/mirrors/fake_function_test.dart (right):
> 
>
https://codereview.chromium.org/22625003/diff/5001/tests/lib/mirrors/fake_fun...
> tests/lib/mirrors/fake_function_test.dart:11: method();
> Can you add a body for it so that it can be invoked and the result verified
(see
> comment below).
> 
>
https://codereview.chromium.org/22625003/diff/5001/tests/lib/mirrors/fake_fun...
> tests/lib/mirrors/fake_function_test.dart:25: "Wrong arity");
> Can you also add a test to invoke "method" using cm.

Done.

[siva, 2013-08-07 23:41:12]

lgtm

[rmacnak, 2013-08-08 20:25:53]

Committed patchset #3 manually as r25944 (presubmit successful).