Issue 226183013: Don't create special path characters on windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 226183013: Don't create special path characters on windows. (Closed)

Created:
6 years, 8 months ago by Anders Johnsen

Modified:
6 years, 8 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't create special path characters on windows. BUG= Committed: https://code.google.com/p/dart/source/detail?r=34770

Patch Set 1 #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -23 lines)			Patch
	M	pkg/http_server/test/virtual_directory_test.dart	View		2 chunks	+23 lines, -23 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Committed patchset #1 manually as r34770 (presubmit successful).

6 years, 8 months ago (2014-04-07 07:36:28 UTC) #2

Søren Gjesse

lgtm https://codereview.chromium.org/226183013/diff/1/pkg/http_server/test/virtual_directory_test.dart File pkg/http_server/test/virtual_directory_test.dart (right): https://codereview.chromium.org/226183013/diff/1/pkg/http_server/test/virtual_directory_test.dart#newcode169 pkg/http_server/test/virtual_directory_test.dart:169: new Directory('${dir.path}/javascript:alert(document);"').createSync(); Long line.

6 years, 8 months ago (2014-04-07 07:53:54 UTC) #3

Anders Johnsen

6 years, 8 months ago (2014-04-07 09:11:43 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/226183013/diff/1/pkg/http_server/test/virtual...
File pkg/http_server/test/virtual_directory_test.dart (right):

https://codereview.chromium.org/226183013/diff/1/pkg/http_server/test/virtual...
pkg/http_server/test/virtual_directory_test.dart:169: new
Directory('${dir.path}/javascript:alert(document);"').createSync();
On 2014/04/07 07:53:54, Søren Gjesse wrote:
> Long line.

Done.

Expand Messages | Collapse Messages