Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2261453002: Implement missing interface member in mock ModelDB (Closed)

Created:
4 years, 4 months ago by Bill Hesse
Modified:
4 years, 4 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/gcloud.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement missing interface member in mock ModelDB This fixes an analyzer warning BUG= R=kustermann@google.com Committed: https://github.com/dart-lang/gcloud/commit/c2ae6a2cd0ac883ae899246f25ff0163fe4866ad

Patch Set 1 #

Patch Set 2 : Version 0.2.0+14 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M CHANGELOG.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M test/db/properties_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Bill Hesse
4 years, 4 months ago (2016-08-18 13:27:19 UTC) #1
kustermann
lgtm
4 years, 4 months ago (2016-08-18 14:03:24 UTC) #2
Bill Hesse
Updated version number and changelog.
4 years, 4 months ago (2016-08-18 14:24:16 UTC) #3
Bill Hesse
Committed patchset #2 (id:20001) manually as c2ae6a2cd0ac883ae899246f25ff0163fe4866ad (presubmit successful).
4 years, 4 months ago (2016-08-18 14:24:45 UTC) #5
kustermann
There is no reason for version/changelog update, it's just a test.
4 years, 4 months ago (2016-08-18 14:42:02 UTC) #6
Bill Hesse
4 years, 4 months ago (2016-08-18 15:15:14 UTC) #7
Message was sent while issue was closed. 
On 2016/08/18 14:42:02, kustermann wrote:
> There is no reason for version/changelog update, it's just a test.

OK, I was thinking that users would be getting the analyzer warning, so they
would want to update, and we can't do that without publishing to pub.
But user's applications only link to the library, not the tests, so they won't
get the analyzer warning, so you are right.

Powered by Google App Engine
This is Rietveld 408576698