Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22607005: Remove race(s) in vmservice tests. (Closed)

Created:
7 years, 4 months ago by Cutch
Modified:
7 years, 4 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, siva
Visibility:
Public.

Description

Remove race(s) in vmservice tests. BUG=https://code.google.com/p/dart/issues/detail?id=12294 R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=25927

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -45 lines) Patch
M runtime/bin/main.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M runtime/bin/vmservice/running_isolate.dart View 2 chunks +2 lines, -21 lines 0 comments Download
M runtime/bin/vmservice/running_isolates.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/vmservice.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/vmservice_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice_impl.cc View 2 chunks +18 lines, -10 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/vmservice/isolate_stacktrace_command_script.dart View 2 chunks +1 line, -1 line 0 comments Download
M tests/standalone/vmservice/multiple_isolate_list_script.dart View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Cutch
7 years, 4 months ago (2013-08-07 22:39:38 UTC) #1
Ivan Posva
https://codereview.chromium.org/22607005/diff/1/runtime/bin/main.cc File runtime/bin/main.cc (right): https://codereview.chromium.org/22607005/diff/1/runtime/bin/main.cc#newcode514 runtime/bin/main.cc:514: Dart_EnterIsolate(isolate); You cannot enter the isolate after having made ...
7 years, 4 months ago (2013-08-07 23:33:38 UTC) #2
Cutch
https://codereview.chromium.org/22607005/diff/1/runtime/bin/main.cc File runtime/bin/main.cc (right): https://codereview.chromium.org/22607005/diff/1/runtime/bin/main.cc#newcode514 runtime/bin/main.cc:514: Dart_EnterIsolate(isolate); On 2013/08/07 23:33:38, Ivan Posva wrote: > You ...
7 years, 4 months ago (2013-08-08 14:26:38 UTC) #3
Ivan Posva
LGTM -ip
7 years, 4 months ago (2013-08-08 15:25:17 UTC) #4
Cutch
7 years, 4 months ago (2013-08-08 15:44:27 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 manually as r25927 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698