Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2260633002: Add more input types, fix lowercase nodeName, support shift-backspace (Closed)

Created:
4 years, 4 months ago by Pam (message me for reviews)
Modified:
4 years, 4 months ago
Reviewers:
ojan
Base URL:
https://chromium.googlesource.com/chromium/extensions-by-google.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add more input types, fix lowercase nodeName, support shift-backspace Add the date, datetime, datetime-local, month, time, url, and week input types. Force node names to upper case and node types to lower case before comparison. Support shift-backspace to go forward, and ignore other modified-backspace keypresses (i.e. alt-, ctrl-, and meta-backspace). BUG=638645, 637983, 638469 R=ojan@chromium.org Committed: https://chromium.googlesource.com/chromium/extensions-by-google/05efa01c40b34bf3d1aa32662663caee1155773d

Patch Set 1 #

Patch Set 2 : Add note about reloading tabs #

Patch Set 3 : Remove trailing CR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -10 lines) Patch
M go-back-with-backspace/content_script.js View 1 chunk +7 lines, -3 lines 0 comments Download
M go-back-with-backspace/is_editable.js View 1 chunk +14 lines, -6 lines 0 comments Download
M go-back-with-backspace/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M go-back-with-backspace/readme.txt View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Pam (message me for reviews)
Add note about reloading tabs
4 years, 4 months ago (2016-08-18 21:45:11 UTC) #1
ojan
lgtm
4 years, 4 months ago (2016-08-19 21:30:06 UTC) #2
Pam (message me for reviews)
4 years, 4 months ago (2016-08-19 21:36:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
05efa01c40b34bf3d1aa32662663caee1155773d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698