Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 22594012: Treat EventTarget as a secondary superclass (Closed)

Created:
7 years, 4 months ago by vsm
Modified:
7 years, 4 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Treat EventTarget as a secondary superclass This matches the C++. It's brittle, but it's not clear how to get this out of idl right now. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=25906

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M tests/html/html.status View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/dom/idl/dart/dart.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/scripts/database.py View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsm
7 years, 4 months ago (2013-08-07 22:00:53 UTC) #1
blois
lgtm
7 years, 4 months ago (2013-08-07 22:06:01 UTC) #2
vsm
7 years, 4 months ago (2013-08-07 22:15:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r25906 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698