Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 225893002: Refactor code to prepare for line-based tokenization. (Closed)

Created:
6 years, 8 months ago by ahe
Modified:
6 years, 8 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, lukechurch
Visibility:
Public.

Description

Refactor code to prepare for line-based tokenization. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=34775

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -69 lines) Patch
M dart/site/try/src/html_to_text.dart View 3 chunks +11 lines, -3 lines 0 comments Download
M dart/site/try/src/interaction_manager.dart View 5 chunks +57 lines, -48 lines 0 comments Download
M dart/site/try/src/selection.dart View 2 chunks +11 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ahe
Covered by existing tests.
6 years, 8 months ago (2014-04-04 13:01:29 UTC) #1
kasperl
LGTM.
6 years, 8 months ago (2014-04-04 13:13:41 UTC) #2
ahe
6 years, 8 months ago (2014-04-07 09:32:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34775 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698