Annotation whitespace convention fixes (dartbug.com/17837).

Annotation whitespace convention fixes (dartbug.com/17837).

R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34902

[scheglov, 2014-04-09 22:12:54]

lgtm

https://codereview.chromium.org/225863005/diff/1/pkg/analyzer/lib/src/service...
File pkg/analyzer/lib/src/services/formatter_impl.dart (right):

https://codereview.chromium.org/225863005/diff/1/pkg/analyzer/lib/src/service...
pkg/analyzer/lib/src/services/formatter_impl.dart:1406:
preserveLeadingNewlines();}, followedBy: space);
This code is very hard to read.
Ending a block in the middle of the line...

Could it be reformatted as?

  visitNodes(metadata, 
    separatedBy: () {
      space();
      preserveLeadingNewlines();
    },
    followedBy: space);

[pquitslund, 2014-04-09 22:22:17]

https://codereview.chromium.org/225863005/diff/1/pkg/analyzer/lib/src/service...
File pkg/analyzer/lib/src/services/formatter_impl.dart (right):

https://codereview.chromium.org/225863005/diff/1/pkg/analyzer/lib/src/service...
pkg/analyzer/lib/src/services/formatter_impl.dart:1406:
preserveLeadingNewlines();}, followedBy: space);
Yes! :)  Done.

On 2014/04/09 22:12:54, scheglov wrote:
> This code is very hard to read.
> Ending a block in the middle of the line...
> 
> Could it be reformatted as?
> 
>   visitNodes(metadata, 
>     separatedBy: () {
>       space();
>       preserveLeadingNewlines();
>     },
>     followedBy: space);

[pquitslund, 2014-04-09 22:22:35]

Committed patchset #2 manually as r34902 (presubmit successful).

[Brian Wilkerson, 2014-04-10 22:19:53]

LGTM