Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 22574002: Fix exitcode handling from analyzer running in nobatch mode. (Closed)

Created:
7 years, 4 months ago by ricow1
Modified:
7 years, 4 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, scheglov
Visibility:
Public.

Description

Fix exitcode handling from analyzer running in nobatch mode. R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=25871

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/testing/dart/test_runner.dart View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
7 years, 4 months ago (2013-08-07 12:15:14 UTC) #1
kustermann
LGTM
7 years, 4 months ago (2013-08-07 12:19:28 UTC) #2
ricow1
Konstantin: FYI Passing --nobatch to the testing script was actually broken prior to revision 25760
7 years, 4 months ago (2013-08-07 12:27:52 UTC) #3
ricow1
7 years, 4 months ago (2013-08-07 12:28:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r25871 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698