Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2256623003: Fix more strong mode errors and warnings. (Closed)

Created:
4 years, 4 months ago by nweiz
Modified:
4 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -33 lines) Patch
M lib/src/asset/dart/serialize/get_input_transform.dart View 1 chunk +8 lines, -5 lines 0 comments Download
M lib/src/barback/transformer_id.dart View 1 chunk +8 lines, -5 lines 0 comments Download
M lib/src/barback/web_socket_api.dart View 2 chunks +5 lines, -6 lines 0 comments Download
M lib/src/command/build.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/flutter.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/git.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M lib/src/io.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/utils.dart View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 4 months ago (2016-08-17 23:44:21 UTC) #1
Bob Nystrom
lgtm
4 years, 4 months ago (2016-08-18 16:19:48 UTC) #2
nweiz
4 years, 4 months ago (2016-08-18 22:04:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
83fc6ebee121b2010b1c5a2478f61d8c1a8eadf0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698