Make the values of Platform.executable and Platform.script available to all isolates

Make the values of Platform.executable and Platform.script available to all isolates

BUG=http://dartbug.com/12258

R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25913

[Bill Hesse, 2013-08-07 13:39:44]

https://codereview.chromium.org/22565003/diff/1/runtime/bin/platform.h
File runtime/bin/platform.h (right):

https://codereview.chromium.org/22565003/diff/1/runtime/bin/platform.h#newcode41
runtime/bin/platform.h:41: static char* GetExecutableName() {
Could these all be const char*?

https://codereview.chromium.org/22565003/diff/1/sdk/lib/io/platform_impl.dart
File sdk/lib/io/platform_impl.dart (right):

https://codereview.chromium.org/22565003/diff/1/sdk/lib/io/platform_impl.dart...
sdk/lib/io/platform_impl.dart:29: static String get executable {
_executable() can never return null.  It returns a string, or it throws an
exception.

It almost seems like we could do
static String executable = _executable();
except that we may have no guarantee that the initialization is lazy on
platforms where _executable() throws an exception.

So, unless we cache explicitly with
get executable {
  if (executableCache == null) {
    executableCache = _executable();
  }
  return executableCache;
}

we might as well just call _executable() from Platform.executable.  This
function does nothing.

https://codereview.chromium.org/22565003/diff/1/tests/standalone/io/platform_...
File tests/standalone/io/platform_test.dart (right):

https://codereview.chromium.org/22565003/diff/1/tests/standalone/io/platform_...
tests/standalone/io/platform_test.dart:53: print("Executable outside isolate:
'${new Options().executable}'");
Remove debug printing

https://codereview.chromium.org/22565003/diff/1/tests/standalone/io/platform_...
tests/standalone/io/platform_test.dart:56: var futures = new List(4);
Could you use a list literal here?
Futures.wait([sendPort.call('Platform.executable'),
              sendPort.call('...
).then

[Søren Gjesse, 2013-08-07 14:37:46]

https://codereview.chromium.org/22565003/diff/1/runtime/bin/platform.h
File runtime/bin/platform.h (right):

https://codereview.chromium.org/22565003/diff/1/runtime/bin/platform.h#newcode41
runtime/bin/platform.h:41: static char* GetExecutableName() {
On 2013/08/07 13:39:44, Bill Hesse wrote:
> Could these all be const char*?

Done.

https://codereview.chromium.org/22565003/diff/1/sdk/lib/io/platform_impl.dart
File sdk/lib/io/platform_impl.dart (right):

https://codereview.chromium.org/22565003/diff/1/sdk/lib/io/platform_impl.dart...
sdk/lib/io/platform_impl.dart:29: static String get executable {
On 2013/08/07 13:39:44, Bill Hesse wrote:
> _executable() can never return null.  It returns a string, or it throws an
> exception.
> 
> It almost seems like we could do
> static String executable = _executable();
> except that we may have no guarantee that the initialization is lazy on
> platforms where _executable() throws an exception.
> 
> So, unless we cache explicitly with
> get executable {
>   if (executableCache == null) {
>     executableCache = _executable();
>   }
>   return executableCache;
> }
> 
> we might as well just call _executable() from Platform.executable.  This
> function does nothing.

Initially I was expecting to handle NULL, but it can never happen. Changed to be
just

static String executable = _executable();

https://codereview.chromium.org/22565003/diff/1/tests/standalone/io/platform_...
File tests/standalone/io/platform_test.dart (right):

https://codereview.chromium.org/22565003/diff/1/tests/standalone/io/platform_...
tests/standalone/io/platform_test.dart:53: print("Executable outside isolate:
'${new Options().executable}'");
On 2013/08/07 13:39:44, Bill Hesse wrote:
> Remove debug printing

Done.

https://codereview.chromium.org/22565003/diff/1/tests/standalone/io/platform_...
tests/standalone/io/platform_test.dart:56: var futures = new List(4);
On 2013/08/07 13:39:44, Bill Hesse wrote:
> Could you use a list literal here?
> Futures.wait([sendPort.call('Platform.executable'),
>               sendPort.call('...
> ).then

Done.

[Ivan Posva, 2013-08-08 00:37:13]

LGTM -ip

[Søren Gjesse, 2013-08-08 07:19:29]

Committed patchset #2 manually as r25913 (presubmit successful).