Bump analyzer dependency in package test (#452).

Bump analyzer dependency.

Updates `test` to be constraint-compatible with the latest analyzer (0.28.0-alpha.1).

BUG=
R=brianwilkerson@google.com, nweiz@google.com

Committed: https://github.com/dart-lang/test/commit/91b3156b19d3778e84571f5256f0f56748395116

[pquitslund, 2016-08-18 16:53:50]

Description was changed from

==========
Bump analyzer dependency.

Updates `test` to be constraint-compatible with the latest analyzer
(0.28.0-alpha.1).

BUG=
==========

to

==========
Bump analyzer dependency.

Updates `test` to be constraint-compatible with the latest analyzer
(0.28.0-alpha.1).

BUG=
==========

[pquitslund, 2016-08-18 17:00:15]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, nweiz@google.com

[pquitslund, 2016-08-18 17:00:16]

This is a pressing issue for flutter since it means we can't update to the
latest SDK and get a corresponding version of analyzer (for flutter analyze).

See: https://github.com/dart-lang/test/issues/452

Once this (or something like it lands), we'll need to publish.

Thanks in advance!

[Brian Wilkerson, 2016-08-18 17:28:41]

lgtm

[nweiz, 2016-08-18 20:08:08]

This worries me. There's no stable release of analyzer 0.28.0, nor is there any
documentation of what the breaking changes are from 0.27.0. Can you guarantee
that none of the breaking changes affect test, and that there will be no further
breaking changes before 0.28.0 stable is released?

[pquitslund, 2016-08-18 20:35:21]

On 2016/08/18 20:08:08, nweiz wrote:
> This worries me. There's no stable release of analyzer 0.28.0, nor is there
any
> documentation of what the breaking changes are from 0.27.0. Can you guarantee
> that none of the breaking changes affect test, and that there will be no
further
> breaking changes before 0.28.0 stable is released?

Nope.  Not any more than we could *ever* guarantee that a change wouldn't affect
test.  My expectation is that any breaking changes would get caught by tests. 
This is the approach we've taken in the linter, for example, which reaches
deeply into analyzer internals and in practice hasn't been a big deal.  My
understanding is that `test` has minimal dependencies on analyzer so I'd expect
it even more immune and moreover easy to verify in tests.

[nweiz, 2016-08-18 22:04:18]

On 2016/08/18 20:35:21, pquitslund wrote:
> On 2016/08/18 20:08:08, nweiz wrote:
> > This worries me. There's no stable release of analyzer 0.28.0, nor is there
> any
> > documentation of what the breaking changes are from 0.27.0. Can you
guarantee
> > that none of the breaking changes affect test, and that there will be no
> further
> > breaking changes before 0.28.0 stable is released?
> 
> Nope.  Not any more than we could *ever* guarantee that a change wouldn't
affect
> test.  My expectation is that any breaking changes would get caught by tests. 
> This is the approach we've taken in the linter, for example, which reaches
> deeply into analyzer internals and in practice hasn't been a big deal.  My
> understanding is that `test` has minimal dependencies on analyzer so I'd
expect
> it even more immune and moreover easy to verify in tests.

We *definitely* can't release a version of test that promises to support all
versions of analyzer 0.28.0 if we can't guarantee that it will actually work
with those versions.

What's the timeline on shipping a stable release with an updated changelog?

[pquitslund, 2016-08-22 20:25:10]

On 2016/08/18 22:04:18, nweiz wrote:
> On 2016/08/18 20:35:21, pquitslund wrote:
> > On 2016/08/18 20:08:08, nweiz wrote:
> > > This worries me. There's no stable release of analyzer 0.28.0, nor is
there
> > any
> > > documentation of what the breaking changes are from 0.27.0. Can you
> guarantee
> > > that none of the breaking changes affect test, and that there will be no
> > further
> > > breaking changes before 0.28.0 stable is released?
> > 
> > Nope.  Not any more than we could *ever* guarantee that a change wouldn't
> affect
> > test.  My expectation is that any breaking changes would get caught by
tests. 
> > This is the approach we've taken in the linter, for example, which reaches
> > deeply into analyzer internals and in practice hasn't been a big deal.  My
> > understanding is that `test` has minimal dependencies on analyzer so I'd
> expect
> > it even more immune and moreover easy to verify in tests.
> 
> We *definitely* can't release a version of test that promises to support all
> versions of analyzer 0.28.0 if we can't guarantee that it will actually work
> with those versions.

NP.

> 
> What's the timeline on shipping a stable release with an updated changelog?

A stable 0.28.0 has now been published.  The changelog needs love but no API
that affects `test` has been changed.

[pquitslund, 2016-08-23 16:34:12]

On 2016/08/22 20:25:10, pquitslund wrote:
> On 2016/08/18 22:04:18, nweiz wrote:
> > On 2016/08/18 20:35:21, pquitslund wrote:
> > > On 2016/08/18 20:08:08, nweiz wrote:
> > > > This worries me. There's no stable release of analyzer 0.28.0, nor is
> there
> > > any
> > > > documentation of what the breaking changes are from 0.27.0. Can you
> > guarantee
> > > > that none of the breaking changes affect test, and that there will be no
> > > further
> > > > breaking changes before 0.28.0 stable is released?
> > > 
> > > Nope.  Not any more than we could *ever* guarantee that a change wouldn't
> > affect
> > > test.  My expectation is that any breaking changes would get caught by
> tests. 
> > > This is the approach we've taken in the linter, for example, which reaches
> > > deeply into analyzer internals and in practice hasn't been a big deal.  My
> > > understanding is that `test` has minimal dependencies on analyzer so I'd
> > expect
> > > it even more immune and moreover easy to verify in tests.
> > 
> > We *definitely* can't release a version of test that promises to support all
> > versions of analyzer 0.28.0 if we can't guarantee that it will actually work
> > with those versions.
> 
> NP.
> 
> > 
> > What's the timeline on shipping a stable release with an updated changelog?
> 
> A stable 0.28.0 has now been published.  The changelog needs love but no API
> that affects `test` has been changed.

(Hopefully) polite ping.  Another dev build for the SDK has been cooked and I
*really* want to get Flutter back on track...  Thanks in advance!

[nweiz, 2016-08-23 20:27:32]

Please bump the test version to 0.12.15+4 and add a CHANGELOG entry mentioning
that this supports the latest analyzer.

[pquitslund, 2016-08-23 22:29:43]

On 2016/08/23 20:27:32, nweiz wrote:
> Please bump the test version to 0.12.15+4 and add a CHANGELOG entry mentioning
> that this supports the latest analyzer.

Done.

Thanks!

[nweiz, 2016-08-23 22:33:04]

LGTM!

[pquitslund, 2016-08-23 22:34:51]

On 2016/08/23 22:33:04, nweiz wrote:
> LGTM!

\o/

[pquitslund, 2016-08-23 22:35:11]

Description was changed from

==========
Bump analyzer dependency.

Updates `test` to be constraint-compatible with the latest analyzer
(0.28.0-alpha.1).

BUG=
==========

to

==========
Bump analyzer dependency.

Updates `test` to be constraint-compatible with the latest analyzer
(0.28.0-alpha.1).

BUG=
R=brianwilkerson@google.com, nweiz@google.com

Committed:
https://github.com/dart-lang/test/commit/91b3156b19d3778e84571f5256f0f5674839...
==========

[pquitslund, 2016-08-23 22:35:12]

Committed patchset #2 (id:20001) manually as
91b3156b19d3778e84571f5256f0f56748395116 (presubmit successful).