Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 225323005: Update HTTP documentation (Closed)

Created:
6 years, 8 months ago by Søren Gjesse
Modified:
6 years, 8 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 10

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
M sdk/lib/io/http.dart View 1 6 chunks +37 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
6 years, 8 months ago (2014-04-04 12:50:39 UTC) #1
Anders Johnsen
LGTM, with comments. https://codereview.chromium.org/225323005/diff/1/sdk/lib/io/http.dart File sdk/lib/io/http.dart (right): https://codereview.chromium.org/225323005/diff/1/sdk/lib/io/http.dart#newcode928 sdk/lib/io/http.dart:928: * The request headers are immutable. ...
6 years, 8 months ago (2014-04-04 12:56:40 UTC) #2
Søren Gjesse
Committed patchset #2 manually as r34733 (presubmit successful).
6 years, 8 months ago (2014-04-04 13:05:27 UTC) #3
Søren Gjesse
6 years, 8 months ago (2014-04-04 13:06:13 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/225323005/diff/1/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/225323005/diff/1/sdk/lib/io/http.dart#newcode928
sdk/lib/io/http.dart:928: * The request headers are immutable.
On 2014/04/04 12:56:40, Anders Johnsen wrote:
> This looks like half a copy of the above line. Consider:
> 
>   The returned [HttpHeaders] are immutable.

Done.

https://codereview.chromium.org/225323005/diff/1/sdk/lib/io/http.dart#newcode...
sdk/lib/io/http.dart:1051: * to. Setting the status code after writing to the
body will throw
On 2014/04/04 12:56:40, Anders Johnsen wrote:
> or closed.

Done.

https://codereview.chromium.org/225323005/diff/1/sdk/lib/io/http.dart#newcode...
sdk/lib/io/http.dart:1061: * to. Setting the reason phrase after writing to the
body will throw
On 2014/04/04 12:56:40, Anders Johnsen wrote:
> ditto.

Done.

https://codereview.chromium.org/225323005/diff/1/sdk/lib/io/http.dart#newcode...
sdk/lib/io/http.dart:1089: * to. After that they become immutable.
On 2014/04/04 12:56:40, Anders Johnsen wrote:
> ditto.

Done.

https://codereview.chromium.org/225323005/diff/1/sdk/lib/io/http.dart#newcode...
sdk/lib/io/http.dart:1569: * The client request headers can be modified until
the body is
On 2014/04/04 12:56:40, Anders Johnsen wrote:
> ditto, and below

Done.

Powered by Google App Engine
This is Rietveld 408576698