Issue 225303006: Corrected resubmssion of r34736.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 225303006: Corrected resubmssion of r34736. (Closed)

Created:
6 years, 8 months ago by koda

Modified:
6 years, 8 months ago

Reviewers:

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Corrected resubmssion of r34736. Fix: Division by page size in NeedsGarbageCollection. Original description: Generalize the interface of page space controller. Gather used/capacity/external into SpaceUsage object, and use it for testing whether GC is needed before or after an allocation. This refactor does not affect policy, but prepares for: 1. Replacing promotion failure check/tracking. 2. Better growth control for external allocation. TBR=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=34747

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+107 lines, -94 lines)			Patch
M	runtime/vm/heap.h	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	runtime/vm/heap.cc	View	4 chunks	+18 lines, -24 lines	0 comments	Download
M	runtime/vm/pages.h	View	7 chunks	+23 lines, -12 lines	0 comments	Download
M	runtime/vm/pages.cc	View	17 chunks	+55 lines, -53 lines	0 comments	Download
M	runtime/vm/scavenger.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
A +	runtime/vm/spaces.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

koda

6 years, 8 months ago (2014-04-04 21:04:52 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r34747 (presubmit successful).

Expand Messages | Collapse Messages