Issue 225183020: Correct or pause previous TimeCounters.

Issue 225183020: Correct or pause previous TimeCounters. (Closed)

Created:
6 years, 8 months ago by scheglov

Modified:
6 years, 8 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Correct or pause previous TimeCounters. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=34809

Patch Set 1 #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+105 lines, -34 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/utilities/general/TimeCounter.java	View	4 chunks	+33 lines, -6 lines	2 comments	Download
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java	View	1 chunk	+53 lines, -25 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/utilities_general.dart	View	4 chunks	+19 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/225183020/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/utilities/general/TimeCounter.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/utilities/general/TimeCounter.java (right): https://codereview.chromium.org/225183020/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/utilities/general/TimeCounter.java#newcode122 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/utilities/general/TimeCounter.java:122: stack.removeFirst(); // should be 'this' We could add ...

6 years, 8 months ago (2014-04-08 04:29:50 UTC) #3

scheglov

Committed patchset #1 manually as r34809 (presubmit successful).

6 years, 8 months ago (2014-04-08 05:08:16 UTC) #4

scheglov

6 years, 8 months ago (2014-04-08 05:08:45 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/225183020/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/utilities/general/TimeCounter.java
(right):

https://codereview.chromium.org/225183020/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/utilities/general/TimeCounter.java:122:
stack.removeFirst(); // should be 'this'
On 2014/04/08 04:29:51, Brian Wilkerson wrote:
> We could add a check, and if the assumption is ever wrong log an informational
> message (with stack trace) so that we'll know that the assumption is wrong.

Done.

Expand Messages | Collapse Messages