Issue 22513002: Fixing polyfill for Element.createShadowRoot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22513002: Fixing polyfill for Element.createShadowRoot. (Closed)

Created:
7 years, 4 months ago by blois

Modified:
7 years, 4 months ago

Reviewers:
vsm, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing polyfill for Element.createShadowRoot. Chrome roll changed it from webkitCreateShadowRoot to createShadowRoot, polyfills need to be updated. This change should probably be reverted once everyone adapts to the new API. TBR BUG= Committed: https://code.google.com/p/dart/source/detail?r=25851

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -7 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	2 chunks	+9 lines, -7 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

blois

Committed patchset #1 manually as r25851 (presubmit successful).

7 years, 4 months ago (2013-08-07 01:33:20 UTC) #1

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages