Issue 22507005: EventTargets should be EventTargets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22507005: EventTargets should be EventTargets (Closed)

Created:
7 years, 4 months ago by vsm

Modified:
7 years, 4 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org, blois

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

EventTargets should be EventTargets systemnative.py keys off the ext_attr. Recent IDL changes removed the EventTarget attribute however. Types marked with isEventTarget are handled specially during GC. R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=25947

Patch Set 1 #

Patch Set 2 : Fix comments #

Total comments: 1

Patch Set 3 : Fix comment line #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -13 lines)			Patch
	M	tests/html/html.status	View		1 chunk	+0 lines, -10 lines	0 comments	Download
	M	tools/dom/scripts/dartgenerator.py	View	1 2	1 chunk	+17 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jacob

lgtm https://chromiumcodereview.appspot.com/22507005/diff/3001/tools/dom/scripts/dartgenerator.py File tools/dom/scripts/dartgenerator.py (right): https://chromiumcodereview.appspot.com/22507005/diff/3001/tools/dom/scripts/dartgenerator.py#newcode217 tools/dom/scripts/dartgenerator.py:217: # Add as an attribute for easy querying ...

7 years, 4 months ago (2013-08-08 21:15:29 UTC) #2

vsm

7 years, 4 months ago (2013-08-08 21:18:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r25947 (presubmit successful).

Expand Messages | Collapse Messages