Add a --[no]-packages-dir flag.

Add a --[no]-packages-dir flag.

This replaces the hidden --no-package-symlinks flag.

Closes #1340

R=rnystrom@google.com

Committed: https://github.com/dart-lang/pub/commit/101aa44a4aebaefd0796ce44e6d155cd79fe2db4

[Bob Nystrom, 2016-08-16 22:19:43]

lgtm

https://codereview.chromium.org/2250643003/diff/1/lib/src/entrypoint.dart
File lib/src/entrypoint.dart (right):

https://codereview.chromium.org/2250643003/diff/1/lib/src/entrypoint.dart#new...
lib/src/entrypoint.dart:183: bool dryRun: false, bool precompile: true, bool
packagesDir: false})
The name "packagesDir" reads like it *is* the packages directory, not whether or
not there should be one. How about maybe "generatePackagesDir"? I know that's
kind of long, though.

[nweiz, 2016-08-16 22:27:57]

https://codereview.chromium.org/2250643003/diff/1/lib/src/entrypoint.dart
File lib/src/entrypoint.dart (right):

https://codereview.chromium.org/2250643003/diff/1/lib/src/entrypoint.dart#new...
lib/src/entrypoint.dart:183: bool dryRun: false, bool precompile: true, bool
packagesDir: false})
On 2016/08/16 22:19:43, Bob Nystrom wrote:
> The name "packagesDir" reads like it *is* the packages directory, not whether
or
> not there should be one. How about maybe "generatePackagesDir"? I know that's
> kind of long, though.

I generally prefer short names to totally unambiguous names, especially for
named parameters. I think the fact that this is the same as the command-line
argument is enough to make it pretty clear.

[nweiz, 2016-08-16 22:29:33]

Description was changed from

==========
Add a --[no]-packages-dir flag.

This replaces the hidden --no-package-symlinks flag.

Closes #1340

R=rnystrom@google.com
==========

to

==========
Add a --[no]-packages-dir flag.

This replaces the hidden --no-package-symlinks flag.

Closes #1340

R=rnystrom@google.com

Committed:
https://github.com/dart-lang/pub/commit/101aa44a4aebaefd0796ce44e6d155cd79fe2db4
==========

[nweiz, 2016-08-16 22:29:34]

Committed patchset #1 (id:1) manually as
101aa44a4aebaefd0796ce44e6d155cd79fe2db4 (presubmit successful).