Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 22488017: Added script to run local files on App Engine (Closed)

Created:
7 years, 4 months ago by Tate Mandel
Modified:
7 years, 4 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org, janicejl
Visibility:
Public.

Description

Added script to run local files on App Engine BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=26035

Patch Set 1 #

Total comments: 11

Patch Set 2 : Fixed README and added more informative help information. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -2 lines) Patch
M pkg/docgen/README.md View 1 3 chunks +51 lines, -2 lines 0 comments Download
A pkg/docgen/bin/dartdoc.py View 1 1 chunk +77 lines, -0 lines 3 comments Download

Messages

Total messages: 5 (0 generated)
Tate Mandel
The script works and now cleans up after itself if you press enter to quit ...
7 years, 4 months ago (2013-08-10 21:06:49 UTC) #1
Emily Fortuna
https://codereview.chromium.org/22488017/diff/1/pkg/docgen/README.md File pkg/docgen/README.md (right): https://codereview.chromium.org/22488017/diff/1/pkg/docgen/README.md#newcode96 pkg/docgen/README.md:96: Running `python dartdoc.py --options=<docgen options> --gae-sdk=<path to SDK>` You've ...
7 years, 4 months ago (2013-08-12 17:04:05 UTC) #2
Tate Mandel
https://codereview.chromium.org/22488017/diff/1/pkg/docgen/README.md File pkg/docgen/README.md (right): https://codereview.chromium.org/22488017/diff/1/pkg/docgen/README.md#newcode96 pkg/docgen/README.md:96: Running `python dartdoc.py --options=<docgen options> --gae-sdk=<path to SDK>` On ...
7 years, 4 months ago (2013-08-12 20:24:04 UTC) #3
Emily Fortuna
lgtm with comments. https://codereview.chromium.org/22488017/diff/1/pkg/docgen/bin/dartdoc.py File pkg/docgen/bin/dartdoc.py (right): https://codereview.chromium.org/22488017/diff/1/pkg/docgen/bin/dartdoc.py#newcode43 pkg/docgen/bin/dartdoc.py:43: help='The options being passed into docgen.') ...
7 years, 4 months ago (2013-08-12 21:05:04 UTC) #4
Tate Mandel
7 years, 4 months ago (2013-08-12 21:23:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r26035 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698