Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 22481002: Issue 12158. Report error when user code uses 'native' clause. (Closed)

Created:
7 years, 4 months ago by scheglov
Modified:
7 years, 4 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Patch Set 1 #

Messages

Total messages: 6 (0 generated)
scheglov
7 years, 4 months ago (2013-08-06 20:43:28 UTC) #1
jwren
On 2013/08/06 20:43:28, scheglov wrote: LGTM
7 years, 4 months ago (2013-08-06 20:55:17 UTC) #2
Brian Wilkerson
LGTM
7 years, 4 months ago (2013-08-06 22:43:25 UTC) #3
scheglov
Committed patchset #1 manually as r25839 (presubmit successful).
7 years, 4 months ago (2013-08-06 22:50:31 UTC) #4
Bill Hesse
On 2013/08/06 22:50:31, scheglov wrote: > Committed patchset #1 manually as r25839 (presubmit successful). Are ...
7 years, 4 months ago (2013-08-07 08:54:58 UTC) #5
Brian Wilkerson
7 years, 4 months ago (2013-08-07 13:47:52 UTC) #6
Message was sent while issue was closed.
> Are you aware that native extensions created by users for the Dart standalone
> executable use
> the 'native' indicator to indicate functions that call into native code?

Yes, but we were told that because native is not included in the specification
we must produce an error when we see it's use. Sounds like we need to get native
into the specification, along with an explanation of why we need both 'external'
and 'native' and when to use one rather than the other.

Powered by Google App Engine
This is Rietveld 408576698