Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 224793002: Simplify and fix instantiation of recursive types. (Closed)

Created:
6 years, 8 months ago by regis
Modified:
6 years, 8 months ago
Reviewers:
srdjan, hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Simplify and fix instantiation of recursive types. Add tests for non-contractive types. Cleanup language tests status file. Enhance tracing of type finalization. R=hausner@google.com, srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=34739

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -105 lines) Patch
M runtime/vm/class_finalizer.cc View 1 8 chunks +62 lines, -19 lines 0 comments Download
M runtime/vm/object.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 9 chunks +69 lines, -42 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/cyclic_type_test.dart View 1 1 chunk +49 lines, -15 lines 0 comments Download
M tests/language/language.status View 1 2 chunks +14 lines, -24 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
regis
6 years, 8 months ago (2014-04-03 23:25:36 UTC) #1
srdjan
lgtm
6 years, 8 months ago (2014-04-04 16:20:04 UTC) #2
hausner
LGTM2. Thanks for adding all the comments.
6 years, 8 months ago (2014-04-04 16:31:42 UTC) #3
regis
Thanks!
6 years, 8 months ago (2014-04-04 18:27:25 UTC) #4
regis
6 years, 8 months ago (2014-04-04 18:27:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r34739 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698