Fix how document fragments are added on NodeList operations

Fix how document fragments are added on NodeList operations. The DocumentFragment node should be gone, and its children should be added in place.

R=jmesserly@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34742

[Jennifer Messerly, 2014-04-04 01:04:03]

lgtm

[Jennifer Messerly, 2014-04-04 01:06:30]

On 2014/04/04 01:04:03, John Messerly wrote:
> lgtm

oops, not lgtm :) I don't think DocumentFragments should be in the middle of the
tree. Talking about it, it sounds like maybe "append" is broken?

[Siggi Cherem (dart-lang), 2014-04-04 17:01:06]

PTAL - I rewrote it now to fix how we add document fragments

[Jennifer Messerly, 2014-04-04 18:24:55]

Thank you so much! Sorry the original code didn't handle this properly. I
realized we could've just patched querySelector/querySelectorAll and left a
TODO, but it's nice that the DOM is going to wrok better for us now :-)

LGTM++

https://codereview.chromium.org/224733003/diff/50001/pkg/third_party/html5lib...
File pkg/third_party/html5lib/lib/dom.dart (right):

https://codereview.chromium.org/224733003/diff/50001/pkg/third_party/html5lib...
pkg/third_party/html5lib/lib/dom.dart:753: insert(index++, node);
this is O(N^2) right? would something like this work:

var list = ...
list = _flattenDocFragments(list);
// Note: unlike the old code, reversed is faster, see comment in addAll
for (var node in list.reversed) _setParent(node);
super.insertAll(index, list);


_flattenDocFragments(list) {
  var result = [];
  for (var node in list) {
    if (node is DocumentFragment) {
      result.addAll(node.nodes);
    } else {
      result.add(node);
    }
  }
  return result;
}

[Siggi Cherem (dart-lang), 2014-04-04 19:31:56]

Thanks!

PTAL at how I combined _flatten + copy together

https://codereview.chromium.org/224733003/diff/50001/pkg/third_party/html5lib...
File pkg/third_party/html5lib/lib/dom.dart (right):

https://codereview.chromium.org/224733003/diff/50001/pkg/third_party/html5lib...
pkg/third_party/html5lib/lib/dom.dart:753: insert(index++, node);
On 2014/04/04 18:24:55, John Messerly wrote:
> this is O(N^2) right? would something like this work:
> 
> var list = ...
> list = _flattenDocFragments(list);
> // Note: unlike the old code, reversed is faster, see comment in addAll
> for (var node in list.reversed) _setParent(node);
> super.insertAll(index, list);
> 
> 
> _flattenDocFragments(list) {
>   var result = [];
>   for (var node in list) {
>     if (node is DocumentFragment) {
>       result.addAll(node.nodes);
>     } else {
>       result.add(node);
>     }
>   }
>   return result;
> }

Good catch. Made the change, also updated addAll to use _flattenDocFragments

[Jennifer Messerly, 2014-04-04 19:44:45]

lgtm, nice simplification

[Siggi Cherem (dart-lang), 2014-04-04 20:19:21]

Committed patchset #3 manually as r34742 (presubmit successful).