Issue 224723017: Fix bug in closure call stub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 224723017: Fix bug in closure call stub. (Closed)

Created:
6 years, 8 months ago by Florian Schneider

Modified:
6 years, 8 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix bug in closure call stub. Since closure calls and method calls both use the same lazy-compile stub, we need a GC-safe value in the IC data register also at closure calls. TBR=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=34777

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -3 lines)			Patch
M	runtime/vm/stub_code_arm.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Florian Schneider

Committed patchset #1 manually as r34777 (presubmit successful).

6 years, 8 months ago (2014-04-07 11:47:18 UTC) #2

Message was sent while issue was closed.

lgtm